Changeset 2626

Timestamp:

11/30/06 04:37:05 (2 years ago)

Author:

gendoh

Message:

Static Code Analysis

• " 안의 \이스케이핑 문제
  
• 사용하지 않는 변수 제거
  
• 불필요한 레퍼런스 파라미터 제거
  

Files:

• branches/1.1-beta/lib/view/view.php (modified) (14 diffs)

branches/1.1-beta/lib/view/view.php

@@ -24 +24 @@
 
 function dress($tag, $value, & $contents) {
-    if (eregi("\[##_{$tag}_##\]", $contents, $temp)) {
+    if (preg_match("@\\[##_{$tag}_##\\]@iU", $contents)) {
         $contents = str_replace("[##_{$tag}_##]", $value, $contents);
         return true;
@@ -357 +357 @@
 }
 
-function getTrackbacksView($entryId, & $skin) {
+function getTrackbacksView($entryId, $skin) {
     global $suri, $defaultURL, $skinSetting, $blogURL, $service;
     $trackbacksContainer = $skin->trackbackContainer;
@@ -392 +392 @@
 }
 
-function getCommentView($entryId, & $skin) {
-    global $database, $blogURL, $service, $owner, $suri, $paging, $blog;
+function getCommentView($entryId, $skin) {
+    global $database, $blogURL, $service, $owner, $suri, $paging;
     //if ($entryId <= 0)
     //  return getGuestCommentView($entryId, $skin);
@@ -402 +402 @@
         $prefix1 = 'rp';
         $isComment = true;
-        $SubItem = 'commentSubItem';
     } else {
         $prefix1 = 'guest';
         $isComment = false;
-        $SubItem = 'guestSubItem';
     }
     $commentView = ($isComment ? $skin->comment : $skin->guest);
@@ -559 +557 @@
 }
 
-function getGuestCommentView($entryId, & $skin) {
+function getGuestCommentView($entryId, $skin) {
     global $blogURL, $owner, $suri, $paging, $blog, $skinSetting;
     $authorized = doesHaveOwnership();
@@ -565 +563 @@
         $prefix1 = 'rp';
         $isComment = true;
-        $SubItem = 'commentSubItem';
     } else {
         $prefix1 = 'guest';
         $isComment = false;
-        $SubItem = 'guestSubItem';
     }
     $commentView = "<form method=\"post\" action=\"$blogURL/comment/add/$entryId\" onsubmit=\"return false\" style=\"margin: 0\">" . ($isComment ? $skin->comment : $skin->guest) . '</form>';
@@ -981 +977 @@
 }
 
-function getArchivesView($archives, & $template) {
+function getArchivesView($archives, $template) {
     global $blogURL;
     ob_start();
@@ -1098 +1094 @@
 }
 
-function getRecentEntriesView($entries, & $template) {
+function getRecentEntriesView($entries, $template) {
     global $blogURL, $skinSetting;
     ob_start();
@@ -1113 +1109 @@
 }
 
-function getRecentCommentsView($comments, & $template) {
+function getRecentCommentsView($comments, $template) {
     global $blogURL, $skinSetting;
     ob_start();
@@ -1129 +1125 @@
 }
 
-function getRecentTrackbacksView($trackbacks, & $template) {
+function getRecentTrackbacksView($trackbacks, $template) {
     global $blogURL, $skinSetting;
     ob_start();
@@ -1145 +1141 @@
 }
 
-function getLinksView($links, & $template) {
+function getLinksView($links, $template) {
     global $blogURL, $skinSetting;
     ob_start();
@@ -1159 +1155 @@
 }
 
-function getRandomTagsView($tags, & $template) {
+function getRandomTagsView($tags, $template) {
     global $blogURL;
     ob_start();
@@ -1283 +1279 @@
         $attributes = explode('|', substr($view, $start + 4, $end - $start - 4));
         $prefix = '';
-        $postfix = '';
         $buf = '';
         if ($attributes[0] == 'Gallery') {
@@ -1830 +1825 @@
                                                 <div id="entryHead">
                                                     <div class="title"><a href="<?php echo htmlspecialchars($entry['permalink']);?>" onclick="window.open(this.href); return false;"><?php echo htmlspecialchars($entry['entry_title']);?></a></div>
-                                                    <div class="writing-info"><span class="by">by </span><span class="name"><?php echo htmlspecialchars($entry['author'] ? eregi_replace("^\((.+)\)$", "\\1", $entry['author']) : $entry['blog_title']);?></span><span class="divider"> : </span><span class="date"><?php echo date('Y-m-d H:i:s', $entry['written']);?></span></div>
+                                                    <div class="writing-info"><span class="by">by </span><span class="name"><?php echo htmlspecialchars($entry['author'] ? eregi_replace("^\\((.+)\\)$", "\\1", $entry['author']) : $entry['blog_title']);?></span><span class="divider"> : </span><span class="date"><?php echo date('Y-m-d H:i:s', $entry['written']);?></span></div>
                                                     <div class="open"><a id="entryPermalink" href="<?php echo htmlspecialchars($entry['permalink']);?>" onclick="window.open(this.href); return false;" title="<?php echo _t('이 포스트를 새 창으로 엽니다.');?>"><span class="text"><?php echo _t('새 창으로');?></span></a></div>
                                                 </div>